Expand javadoc on NodeInfo #132665
Merged
Expand javadoc on NodeInfo #132665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Move the javadoc from Node#info onto NodeInfo and make it clearer what it's used for.
alex-spies
force-pushed
the
improve-nodeinfo-javadoc
branch
from
d570b49 to
d640819
Compare
not-napoleon
approved these changes
Aug 11, 2025
Member
not-napoleon
left a comment
not-napoleon
left a comment
There was a problem hiding this comment.
this is definitely more clear than it was.
nik9000
approved these changes
Aug 11, 2025
Contributor
Author
|
CI failed due to a now-muted test, namely #132672. I think it's not worth re-running CI for this simple javadoc change, this is safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the javadoc from Node#info onto NodeInfo and make it clearer what it's used for.